Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): remove parseWithNodeMaps #7120

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Removes the exported parseWithNodeMaps & associated testing.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e1aabd0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/649129cc742c3e000835e4c0
😎 Deploy Preview https://deploy-preview-7120--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link

nx-cloud bot commented Jun 20, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e1aabd0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #7120 (e1aabd0) into v6 (b411706) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #7120      +/-   ##
==========================================
- Coverage   87.50%   87.43%   -0.08%     
==========================================
  Files         372      372              
  Lines       12849    12849              
  Branches     3813     3813              
==========================================
- Hits        11244    11235       -9     
- Misses       1227     1237      +10     
+ Partials      378      377       -1     
Flag Coverage Δ
unittest 87.43% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 20, 2023 18:47
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team June 20, 2023 18:47
@bradzacher bradzacher added this to the 6.0.0 milestone Jun 24, 2023
@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Jun 24, 2023
@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Jun 24, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit e2a0a76 into typescript-eslint:v6 Jun 24, 2023
43 of 46 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-parse-with-node-maps branch June 24, 2023 14:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready breaking change This change will require a new major version to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants