-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add warnOnUnsupportedTypeScript warning message #7172
docs: add warnOnUnsupportedTypeScript warning message #7172
Conversation
Thanks for the PR, @nevvada! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 looks great, thanks! Just the one question - I think we're good to merge either way.
docs/packages/Parser.mdx
Outdated
This option allows you to toggle the warning that the parser will give you if you use a version of TypeScript which is not explicitly supported | ||
This option allows you to toggle the warning that the parser will give you if you use a version of TypeScript which is not explicitly supported. The warning message would look like this: | ||
|
||
```console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is console
a supported language anywhere? I'd think ```plaintext
would be best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point! was thinking maybe console since this is terminal output but plaintext is more semantically accurate, and is supported by mdx/prismjs. updated this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
21ccaab
into
typescript-eslint:main
PR Checklist
Overview
this PR adds the explicit TS warning message to the
warnOnUnsupportedTypeScript
parser config option, found at https://typescript-eslint.io/packages/parser#warnonunsupportedtypescriptversionthis PR will fail until the build is fixed