Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): correct schema autocompletion in playground #7557

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Aug 29, 2023

PR Checklist

Overview

Correct issues with autocompletion:

  • extends displays now list of all available configs instead of indexes
    image
    image
  • rules func-names and logical-assignment-operators display correct options
    image
    image
  • some rules are going to properly autocomplete required array type eg. naming-convention
    image
    image

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d9f61ae
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64fa34c7e26cc5000801520d
😎 Deploy Preview https://deploy-preview-7557--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Aug 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d9f61ae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx build website
✅ Successfully ran 39 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher merged commit ec6a62e into main Sep 8, 2023
47 of 52 checks passed
@bradzacher bradzacher deleted the chore/playground-correct-schema-autocompletion branch September 8, 2023 00:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants