Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ast-spec): exclude tsx fixtures from type-check #7602

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Sep 5, 2023

PR Checklist

Overview

  • exclude tsx files from type-check
  • allow tests to be executed on windows

- allow tests to be executed on windows
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 08e0b7a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64f68f1c2428d90008d8d07d
😎 Deploy Preview https://deploy-preview-7602--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@armano2 armano2 changed the title chore(ast-spec): exclude tsx files from type-check chore(ast-spec): exclude tsx fixtures from type-check Sep 5, 2023
@nx-cloud
Copy link

nx-cloud bot commented Sep 5, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 08e0b7a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 40 targets

Sent with 💌 from NxCloud.

@armano2 armano2 requested review from bradzacher and removed request for JoshuaKGoldberg September 5, 2023 10:36
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Sep 8, 2023
@bradzacher bradzacher merged commit 18d9e43 into main Sep 8, 2023
53 checks passed
@bradzacher bradzacher deleted the fix/exclude-tsx-files-from-typecheck branch September 8, 2023 00:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: v6 branch regression for adding to JSX.IntrinsicAttributes in typecheck task
2 participants