Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix prefer-optional-chain example for the unsafe fixes option #7711

Merged

Conversation

cigui
Copy link
Contributor

@cigui cigui commented Oct 1, 2023

…odifyTheReturnTypeIKnowWhatImDoing in prefer-optional-chain

PR Checklist

Overview

The example for the option allowPotentiallyUnsafeFixesThatModifyTheReturnTypeIKnowWhatImDoing seems like a copy-paste error, which has two equal lines calling acceptsBoolean. The second line should be using optional chain.

…odifyTheReturnTypeIKnowWhatImDoing in prefer-optional-chain
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @cigui!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit 395afa6
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65198a8d466dad00072ec667

@JoshuaKGoldberg JoshuaKGoldberg changed the title docs: fix the example for the option allowPotentiallyUnsafeFixesThatM… docs: fix prefer-optional-chain example for the unsafe fixes option Oct 8, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 😄 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8f4d939 into typescript-eslint:main Oct 8, 2023
43 of 48 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants