Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): [no-unsafe-member-access] correct example idx from const to let #7833

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

BrianDawson
Copy link
Contributor

@BrianDawson BrianDawson commented Oct 25, 2023

Update variable declaration from const to let so that code can run. Fixes error: Cannot assign to 'idx' because it is a constant.

PR Checklist

Overview

Update variable declaration from const to let
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @BrianDawson!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 52ff723
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6538861307795000085fea66
😎 Deploy Preview https://deploy-preview-7833--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@BrianDawson BrianDawson changed the title docs: Update no-unsafe-member-access.md [no-unsafe-member-access] docs: Update no-unsafe-member-access.md Oct 25, 2023
@BrianDawson BrianDawson changed the title [no-unsafe-member-access] docs: Update no-unsafe-member-access.md docs[no-unsafe-member-access] Update no-unsafe-member-access.md Oct 25, 2023
@BrianDawson BrianDawson changed the title docs[no-unsafe-member-access] Update no-unsafe-member-access.md docs[no-unsafe-member-access]: Update no-unsafe-member-access.md Oct 25, 2023
@BrianDawson BrianDawson changed the title docs[no-unsafe-member-access]: Update no-unsafe-member-access.md docs(eslint-plugin): [no-unsafe-member-access] Update no-unsafe-member-access.md Oct 25, 2023
@BrianDawson BrianDawson changed the title docs(eslint-plugin): [no-unsafe-member-access] Update no-unsafe-member-access.md docs(eslint-plugin): [no-unsafe-member-access] update no-unsafe-member-access.md Oct 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title docs(eslint-plugin): [no-unsafe-member-access] update no-unsafe-member-access.md docs(eslint-plugin): [no-unsafe-member-access] correct example idx from const to let Oct 25, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6455278 into typescript-eslint:main Oct 25, 2023
47 of 53 checks passed
@BrianDawson BrianDawson deleted the patch-1 branch October 25, 2023 21:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants