Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): [no-throw-literal] fix typo in example #8006

Merged

Conversation

auvred
Copy link
Member

@auvred auvred commented Nov 29, 2023

PR Checklist

Overview

I just accidentally opened example in the playground and noticed that there is an extra semicolon

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit b3e6342
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/656c6d44582ca200082bbd7f

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, nice catch - thanks!

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the CI is failing - could you format the file please? yarn format --write should do the trick. Thanks!

(I can soon if you don't have time - I just don't want to take authorship away 🙂)

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 29, 2023
@auvred
Copy link
Member Author

auvred commented Nov 29, 2023

Fixed it, I also removed eslint comments as they are not needed here (?)

@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 3, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 314f034 into typescript-eslint:main Dec 5, 2023
54 of 58 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants