Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [no-useless-template-literals] add fix suggestions #8065

Merged
merged 6 commits into from
Jan 9, 2024
Merged

feat(eslint-plugin): [no-useless-template-literals] add fix suggestions #8065

merged 6 commits into from
Jan 9, 2024

Conversation

StyleShit
Copy link
Contributor

Closes #8056

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @StyleShit!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1d17227
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/657f2b2f8c5c27000814f201
😎 Deploy Preview https://deploy-preview-8065--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @auvred said 😄

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Dec 15, 2023
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 16, 2023
JoshuaKGoldberg
JoshuaKGoldberg requested changes Dec 16, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just asking, not fully in review mode right now)

packages/eslint-plugin/src/rules/no-useless-template-literals.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Dec 16, 2023
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 16, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Dec 16, 2023
auvred
auvred reviewed Dec 17, 2023
View reviewed changes
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that escaping logic might become very complicated :(

packages/eslint-plugin/src/rules/no-useless-template-literals.ts Outdated
Comment on lines 138 to 141
const escapedValue = expression.value.replace(
/([`$])/g,
'\\$1',
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playground

Input:

`some ${'\\${aaa}'} string`

Output:

`some \\${aaa} string`

Playground
Input:

`some ${'\\`'} string`

Output:

`some \\` string`

Copy link
Contributor Author

@StyleShit StyleShit Dec 17, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha those are clever ones
added test cases for them 😄

@StyleShit
Copy link
Contributor Author

Bumping despite only 2 weeks have passed only because it still has the awaiting response badge even though this PR is ready for review @JoshuaKGoldberg

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 awesome! No complaints, this is looking very thorough. Thanks & nice!

@JoshuaKGoldberg JoshuaKGoldberg merged commit c3767ed into typescript-eslint:main Jan 9, 2024
56 of 57 checks passed
@StyleShit StyleShit mentioned this pull request Jan 14, 2024
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auvred auvred auvred left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [no-useless-template-literals] Add fixing suggestions
3 participants
@StyleShit @JoshuaKGoldberg @auvred