fix(eslint-plugin): [no-unnecessary-condition] improve checking optional callee #8178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
This pr improves unnecessary optional chaining checking of
no-unnecessary-condition
.In below example, optional chain in
y()?.
is unnecessary becausey
does not return nullable value.As described in #7912, the current
no-unnecessary-condition
does not check for the following case.I added
isCallExpressionNullableOriginFromCallee
function.This function takes a CallExpression node as an argument. It returns
true
if the call expression's nullable type is origin from callee otherwise returnsfalse
.