Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix incorrect backwards-compat augmentation in TS 5.3 #8181

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Jan 4, 2024

PR Checklist

Overview

This doesn't work any better than before.
It fixes the error on >5.3, but it introduces an error on <TS5.3.

@bradzacher bradzacher added the bug Something isn't working label Jan 4, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b37b4b3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65a202b1a66cdd00082a2fbc
😎 Deploy Preview https://deploy-preview-8181--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradzacher bradzacher changed the title fix(typescript-estree): fix incorrect backwards-compat augmentation i… fix(typescript-estree): fix incorrect backwards-compat augmentation in TS 5.3 Jan 4, 2024
@bradzacher bradzacher closed this Jan 4, 2024
@bradzacher bradzacher deleted the bradzacher-patch-8047 branch January 4, 2024 00:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
@bradzacher bradzacher restored the bradzacher-patch-8047 branch January 13, 2024 02:30
@bradzacher bradzacher deleted the bradzacher-patch-8047 branch January 13, 2024 02:30
@bradzacher bradzacher restored the bradzacher-patch-8047 branch January 13, 2024 02:30
@bradzacher bradzacher reopened this Jan 13, 2024
@bradzacher bradzacher marked this pull request as ready for review January 13, 2024 02:30
@typescript-eslint typescript-eslint unlocked this conversation Jan 13, 2024
@bradzacher bradzacher merged commit c7b0b6c into main Jan 13, 2024
57 checks passed
@bradzacher bradzacher deleted the bradzacher-patch-8047 branch January 13, 2024 03:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSError: Interface 'AssertClause' cannot simultaneously extend types 'ImportAttributes' and 'Node'
1 participant