fix(eslint-plugin): [no-unsafe-assignment] be more specific about error types

[tobySolutions]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-unsafe-assignment] Differentiate a types-error any from a "true" any #8231
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @tobySolutions!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	b70a2ca
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/665d2fb149db430008917a53
😎 Deploy Preview	https://deploy-preview-8304--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🔴 down 8 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JoshuaKGoldberg]

A great start, thanks again for working on this with me!

Requesting changes mostly around adding in more testing. A couple small refactors too. But the functionality looks great! ✨

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b70a2ca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin --coverage=false
• nx test eslint-plugin
• nx test visitor-keys --coverage=false
• nx run types:build
• nx test typescript-eslint --coverage=false
• nx test repo-tools --coverage=false
• nx test type-utils --coverage=false
• nx test typescript-estree --coverage=false
• nx test scope-manager --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run repo-tools:postinstall-script
• nx test utils --coverage=false
• nx test parser --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test eslint-plugin-internal --coverage=false
• nx test ast-spec --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test typescript-estree
• nx test repo-tools
• nx test visitor-keys
• nx test utils
• nx test typescript-eslint
• nx test scope-manager
• nx test type-utils
• nx test parser
• nx test rule-schema-to-typescript-types
• nx test ast-spec
• nx test eslint-plugin-internal
• nx run-many --target=typecheck --parallel
• nx run integration-tests:test
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

👋 @tobySolutions ping, just checking in - is this something you still have the time and energy for? It's still in draft & there are some CI ❌s so we haven't looked at it.

[tobySolutions]

👋 @tobySolutions ping, just checking in - is this something you still have the time and energy for? It's still in draft & there are some CI ❌s so we haven't looked at it.

Definitely Josh! I will resume work on this in a bit. Thank you so very much for checking in! 🙌

[JoshuaKGoldberg]

Progress! 🚀

[JoshuaKGoldberg]

🙌 Great! Thanks for working with me on this @tobySolutions. I'm excited to see a better error message for no-unsafe-assignment on production soon!

Only one change request left from me, to add a bit more to the tests. It's a pretty small thing - so marking as 1 approval to let someone else from the team chime in if the want.

[tobySolutions]

🙌 Great! Thanks for working with me on this @tobySolutions. I'm excited to see a better error message for no-unsafe-assignment on production soon!

Only one change request left from me, to add a bit more to the tests. It's a pretty small thing - so marking as 1 approval to let someone else from the team chime in if the want.

Yay!!!

[Josh-Cena]

If it only changes one rule, then it doesn't fix #8231, only partially

[JoshuaKGoldberg]

Yup - I'm about to post an edit splitting the issue up 😄

[Josh-Cena]

What about other no-unsafe rules?

[JoshuaKGoldberg]

🙌 Filed!

[JoshuaKGoldberg]

This is wonderful, thanks @tobySolutions!

We've got a bunch of issues filed to apply similar improvements to other no-unsafe-* rules. I think once we've gone through those we'll be well-positioned to review our messaging around "error" types and maybe iterate further on how they're explained to users. But that's a battle for another day.

[tobySolutions]

This is wonderful, thanks @tobySolutions!

We've got a bunch of issues filed to apply similar improvements to other no-unsafe-* rules. I think once we've gone through those we'll be well-positioned to review our messaging around "error" types and maybe iterate further on how they're explained to users. But that's a battle for another day.

Thank you so much for being super awesome Josh!!! This was such an amazing experience. I look forward to more contributions

[kirkwaiblinger]

We'll also need a no-duplicate-type-constitutents version of this I think, that doesn't just display the name differently, but also impacts the fixer logic (see also #9344 (comment))