-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(utils): edit getStaticValue function JSDoc description #8625
docs(utils): edit getStaticValue function JSDoc description #8625
Conversation
Thanks for the PR, @developer-bandi! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -50,7 +50,7 @@ const getPropertyName = eslintUtils.getPropertyName as ( | |||
* If the 2nd parameter `initialScope` was given, this function tries to resolve identifier references which are in the | |||
* given node as much as possible. In the resolving way, it does on the assumption that built-in global objects have | |||
* not been modified. | |||
* For example, it considers `Symbol.iterator`, ` String.raw``hello`` `, and `Object.freeze({a: 1}).a` as static. | |||
* For example, it considers `Symbol.iterator`, `Symbol.for('k')` ` String.raw``hello`` `, and `Object.freeze({a: 1}).a` as static but `Symbol('k')` is not static. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
teeny nit, otherwise LGTM!
* For example, it considers `Symbol.iterator`, `Symbol.for('k')` ` String.raw``hello`` `, and `Object.freeze({a: 1}).a` as static but `Symbol('k')` is not static. | |
* For example, it considers `Symbol.iterator`, `Symbol.for('k')`, ` String.raw``hello`` `, and `Object.freeze({a: 1}).a` as static, but `Symbol('k')` is not static. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you. i apply it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 thanks!
PR Checklist
Overview
Edit getStaticValue's jsDoc description to know Symbol('k') is not static but Symbol.for('k') is static