New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-estree): improve error messaging around project files #866
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh, should have checked the statuses first, tests are failing!
08b5c9d
to
d15f7f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
=========================================
- Coverage 94.17% 94.1% -0.07%
=========================================
Files 113 113
Lines 4891 4906 +15
Branches 1362 1366 +4
=========================================
+ Hits 4606 4617 +11
- Misses 163 165 +2
- Partials 122 124 +2
|
Fixes #853
People were having some problems because we now throw errors if files aren't included in the tsconfig.
This PR:
allowJs
/checkJs
are forced on, so that users don't ever have to manually turn it on in their configs.