New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-eslint): fix type errors when using exactOptionalPropertyTypes
#8786
fix(typescript-eslint): fix type errors when using exactOptionalPropertyTypes
#8786
Conversation
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Let's add a new integration test for this to.make sure it works and make sure we don't cause a regression.
Here is the existing integration test:
https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/integration-tests/fixtures/flat-config-types
Let's add a new one that uses exactOptionalPropertyTypes
Let's also update the old (and new one) to include eslint-plugin-playwright
so that we're testing more cases.
exactOptionalPropertyTypes
@bradzacher Unfortunately, fixing the original type error in the linked issue revealed a series of about 20 more type errors of various nested properties in the same fashion, so I had to add a lot more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8786 +/- ##
==========================================
+ Coverage 87.36% 88.01% +0.64%
==========================================
Files 255 405 +150
Lines 12498 14076 +1578
Branches 3923 4121 +198
==========================================
+ Hits 10919 12389 +1470
- Misses 1304 1382 +78
- Partials 275 305 +30
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this! I hate that we need to do this due to the @types/eslint
types but it is what it is.
PR Checklist
Overview
Support
exactOptionalPropertyTypes: true