chore: lint and typecheck top level

[abrahamguo]

PR Checklist

• Addresses an existing open issue: fixes Repo: files outside of packages are not being linted or typechecked #8879
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Ensure all files outside of packages are linted and typechecked.

[typescript-eslint]

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	ec884d6
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/669d61c12c551c0008548e05
😎 Deploy Preview	https://deploy-preview-8880--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ec884d6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin --coverage=false
• nx test eslint-plugin
• nx test typescript-estree --coverage=false
• nx test visitor-keys --coverage=false
• nx test type-utils --coverage=false
• nx test utils --coverage=false
• nx run types:build
• nx test scope-manager --coverage=false
• nx test typescript-eslint --coverage=false
• nx run repo-tools:postinstall-script
• nx test rule-schema-to-typescript-types --coverage=false
• nx test visitor-keys
• nx test parser --coverage=false
• nx test repo-tools --coverage=false
• nx test utils
• nx test type-utils
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test typescript-eslint
• nx test typescript-estree
• nx test scope-manager
• nx test rule-schema-to-typescript-types
• nx test parser
• nx test repo-tools
• nx test ast-spec
• nx test eslint-plugin-internal
• nx test ast-spec --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx run integration-tests:test
• nx run-many --target=typecheck --parallel
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

I'm not a fan of adding in "secondary" code paths, like having two ways of running linting or type checking &&d together. It'd be less code & complexity to get the "primary" (npx nx ...) commands working as expected.

Let's fine a way to include what's under .github/ and tools/ under nx. packages/repo-tools now exists, maybe that's a good place for some files?

[JoshuaKGoldberg]

Thanks for looking into this!

[abrahamguo]

It turns out that wait-for-netlify became unused in #7730

[abrahamguo]

@JoshuaKGoldberg I've moved all scripts from .github and tools into packages/repo-tools.

However, let me know your thoughts about the remaining files which are still at the top level:

eslint.config.js
eslint.config.mjs
jest.config.base.js
typings/eslint-plugin-eslint-comments.d.ts
typings/eslint-plugin-eslint-plugin.d.ts
typings/eslint-plugin-import.d.ts
typings/eslint-plugin-jsdoc.d.ts
typings/eslint-plugin-jest.d.ts
typings/eslint-plugin-jsx-a11y.d.ts
typings/eslint-plugin-react-hooks.d.ts
typings/eslint-plugin-react.d.ts
knip.ts
typings/eslint-plugin-simple-import-sort.d.ts
typings/eslint-plugin-unicorn.d.ts
typings/eslint__eslintrc.d.ts
typings/eslint__js.d.ts

[JoshuaKGoldberg]

This still does the && strategy 😕. Surely there's got to be a way in Nx to set up a project to include root-level files, so the npx nx run-many --target=lint run would include them?

[abrahamguo]

Sure thing, I can look into that

[JamesHenry]

I can provide feedback tomorrow, in all day planning meetings today

[JamesHenry]

Just adding a blocker until I can look tomorrow

[JoshuaKGoldberg]

👋 @JamesHenry is this still something you want to look at?

[JamesHenry]

@abrahamguo I have just updated the repo to use nx latest (19.4.0) and am pulling down your branch now to look at it. I will update the merge conflicts

[JoshuaKGoldberg]

👋 @abrahamguo just checking in, are you still waiting on us for anything?

We're hoping to close out v8 tasks soon, so we're going to start applying more time pressure on this and other PRs that address issues in the v8 milestone. Just a heads up. 🙂

[abrahamguo]

I'm not very familiar with nx, so I'll need to do some research on how to set up a new nx project for the root files.
I'll see if I can look at this sometime in the next week, unless you want to say "linting the root-level files without nx is good enough for now".
However, how does this PR relate to anything happening for v8?

[JamesHenry]

@JoshuaKGoldberg this is my fault I didn’t get to push up my updates before my vacation without my laptop. I return on Friday evening so will get to it this weekend or latest beginning of next week.

thank you @abrahamguo for your patience and understanding

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (863eb86) to head (ec884d6).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8880   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         422      422           
  Lines       14694    14694           
  Branches     4299     4299           
=======================================
  Hits        12997    12997           
  Misses       1372     1372           
  Partials      325      325           

Flag	Coverage Δ
unittest	88.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[JoshuaKGoldberg]

However, how does this PR relate to anything happening for v8?

Heh, the chain is a bit convoluted. It's blocking #8196, which we're considering something we should do internally as a form of validation before launching v8 as stable.