Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix v8 branch snapshots for flat-config-types #9029

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 29, 2024

PR Checklist

Overview

Ran yarn test -u in the package.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ce2a7ce
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/662f9cec514a7c0008ca24b0
😎 Deploy Preview https://deploy-preview-9029--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -16,7 +16,7 @@ exports[`flat-config-types eslint should work successfully 1`] = `
"line": 38,
"message": "'_otherCases' is defined but never used.",
"messageId": "unusedVar",
"nodeType": "Identifier",
"nodeType": null,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ... don't know why this is happening. None of the recent no-unused-vars ESLint PRs seem relevant. But the actual rule seems to work internally. 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8127873 / #8640

This commit changed the context.report from { node, ... } to { loc, ... }
Hence the nodeType is no longer visible in the output as the rule is not reporting against the node.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 29, 2024 13:22
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 1b36f83 into typescript-eslint:v8 Apr 29, 2024
58 of 60 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the v8-flat-config-snapshot-fix branch April 29, 2024 14:48
This was referenced Apr 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants