Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch nx changelog to fix releases #9159

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Thanks to a tip from @JamesHenry, this:

  1. Removes the TypeScript registration, as that's what's crashing
  2. Fixes the changelog renderer path to work as a direct require()

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d3f86c0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6654e7bd24c9240008706ed1
😎 Deploy Preview https://deploy-preview-9159--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

- const r = require(interpolatedChangelogRendererPath);
+ // const rootTsconfigPath = (0, typescript_1.getRootTsConfigPath)();
+ // if (rootTsconfigPath) {
+ // cleanupTranspiler = (0, register_1.registerTsProject)(rootTsconfigPath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just commenting the one line that calls registerTsProject is enough

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a require() call, we need the full JS path:

Cannot find module 'tools/release/changelog-renderer'
  Require stack:
  - /Users/josh/repos/typescript-eslint/node_modules/nx/src/command-line/release/changelog.js
  - /Users/josh/repos/typescript-eslint/node_modules/nx/src/command-line/release/index.js
  - /Users/josh/repos/typescript-eslint/node_modules/nx/release/index.js
  - ...

@@ -141,7 +141,8 @@
"tmp": "0.2.1",
"tsx": "^4.7.2",
"typescript": "5.4.5",
"@nx/eslint@17.3.1": "patch:@nx/eslint@npm%3A17.3.1#./.yarn/patches/@nx-eslint-npm-17.3.1-a2f85d8c50.patch"
"@nx/eslint@17.3.1": "patch:@nx/eslint@npm%3A17.3.1#./.yarn/patches/@nx-eslint-npm-17.3.1-a2f85d8c50.patch",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch can surely be deleted at this point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I would think so yeah. A good followup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9160 👍

@JoshuaKGoldberg JoshuaKGoldberg changed the title ci: patch nx changelog to fix releases chore: patch nx changelog to fix releases May 27, 2024
@JoshuaKGoldberg
Copy link
Member Author

I really really want to promote the v8 beta today for Reasons ™️ so I'm going to quickly merge this now. If something breaks I'm still available to fix things.

@JoshuaKGoldberg JoshuaKGoldberg merged commit d38e118 into typescript-eslint:main May 27, 2024
59 of 62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the patch-nx-changelog-for-release branch May 27, 2024 20:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Weekly release flow is failing on changelogRenderer again
2 participants