-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: patch nx changelog to fix releases #9159
chore: patch nx changelog to fix releases #9159
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- const r = require(interpolatedChangelogRendererPath); | ||
+ // const rootTsconfigPath = (0, typescript_1.getRootTsConfigPath)(); | ||
+ // if (rootTsconfigPath) { | ||
+ // cleanupTranspiler = (0, register_1.registerTsProject)(rootTsconfigPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just commenting the one line that calls registerTsProject is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's a require()
call, we need the full JS path:
Cannot find module 'tools/release/changelog-renderer'
Require stack:
- /Users/josh/repos/typescript-eslint/node_modules/nx/src/command-line/release/changelog.js
- /Users/josh/repos/typescript-eslint/node_modules/nx/src/command-line/release/index.js
- /Users/josh/repos/typescript-eslint/node_modules/nx/release/index.js
- ...
@@ -141,7 +141,8 @@ | |||
"tmp": "0.2.1", | |||
"tsx": "^4.7.2", | |||
"typescript": "5.4.5", | |||
"@nx/eslint@17.3.1": "patch:@nx/eslint@npm%3A17.3.1#./.yarn/patches/@nx-eslint-npm-17.3.1-a2f85d8c50.patch" | |||
"@nx/eslint@17.3.1": "patch:@nx/eslint@npm%3A17.3.1#./.yarn/patches/@nx-eslint-npm-17.3.1-a2f85d8c50.patch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch can surely be deleted at this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha I would think so yeah. A good followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9160 👍
I really really want to promote the v8 beta today for Reasons ™️ so I'm going to quickly merge this now. If something breaks I'm still available to fix things. |
d38e118
into
typescript-eslint:main
PR Checklist
Overview
Thanks to a tip from @JamesHenry, this:
require()