fix(eslint-plugin): [prefer-nullish-coalescing] treat enums and literals as their underlying primitive types #9376
Conversation
…als as their underlying primitive types
|
Thanks for the PR, @jakebailey! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2cc31cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| declare const x: 0 | 1 | 0n | 1n | undefined; | ||
| x || y; | ||
| `, | ||
| output: null, | ||
| options: [ | ||
| { | ||
| ignorePrimitives: { | ||
| string: true, | ||
| number: false, | ||
| boolean: true, | ||
| bigint: true, | ||
| }, | ||
| }, | ||
| ], | ||
| errors: [{ messageId: 'preferNullishOverOr' }], | ||
| }, |
There was a problem hiding this comment.
I believe these tests to have been wrong originally; this says "ignore bigint", and there's a bigint in the union, but the union is not ignored. Now moved up to "valid" (with the other similar tests).
PR Checklist
Overview
The
ignorePrimitivesflag did not treat literals or enums as their underlying primitive types; for enum heavy codebases like TS, settingignorePrimitivesstill leads to hundreds of "please use??" errors even when applying that fix would change behavior.This PR instead uses the
-Likeflags variants, which also match against literals and enum values.I have yet to test this on TS's codebase; just trying to figure out how I can even do that locally... I'll probably just hack the published package, since this change is so small.