fix(eslint-plugin): [pfa] Allow async getter/setter in classes #980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #820, support was added for getters/setters that return async functions, e.g.
Unfortunately, the previous fix only handles getters/setters on objects (the implementation specifically checks for
node.parent.type === 'Property'
).As it turns out, getter/setters on classes have
node.parent.type === 'MethodDeclaration'
, so the following code still generates warnings:This PR addresses the class getter/setter case, by checking if
node.parent.type === 'Property' || node.parent.type === 'MethodDefinition'
.