Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release doesn't have most recent fixes: Could not parse the filter query: unbalanced && operands. #43

Closed
robjbrain opened this issue Jan 31, 2023 · 8 comments

Comments

@robjbrain
Copy link

Description

I'm just doing what I think is the most basic usage of the library.

Model::search('myterm');

But i'm getting the following error:

"Could not parse the filter query: unbalanced && operands."

It looks like this was fixed a month ago: 7a9edba#diff-30cbc8fb802094edb92485725f009b63a895bcc546b84381b550883a17441129R266

However there hasn't been a new release since July so composer is still picking up the old version.

How can I get the latest version?

As it stands right now it seems like this package doesn't work out of the box.

I am on 5.1.0 right now.

@Mwakashem
Copy link

Screenshot from 2023-02-01 14-41-45

FACING THE SAME ISSUE

@Mwakashem
Copy link

Mwakashem commented Feb 1, 2023

@mattmcardle
Copy link

Also facing this issue, back to meilisearch for me :(

@robjbrain
Copy link
Author

Use dev-master in your composer.json instead and it should fix it.

"typesense/laravel-scout-typesense-driver": "dev-master"

@mattmcardle
Copy link

@robjbrain thanks, that seems to have resolved this error, although I'm now encountering #45 😢
Rolling back to 5.1 to run the import, then upgrading to dev-master to get around this issue works though, this has dented my confidence in typesense a bit and I'm not sure if this package is fit for production.

@jasonbosco
Copy link
Member

I’m sorry about the mess here. Part of the problem is that we didn’t have a test suite for this community-contributed library and we continued to make changes to it without adding a test suite, even once we adopted it into the Typesense org. So that let an import bug make its way into a release.

So we rolled back and have now prioritized writing an automated test suite that will run in CI, before we push out any more releases.

Hopefully that will prevent future issues like this.

@manavo
Copy link
Contributor

manavo commented Feb 27, 2023

@jasonbosco could we get a release to add support for Laravel 10 (merged today), even before the test suite is ready? If there are no other changes?

@karakhanyans
Copy link
Collaborator

@manavo @robjbrain

Latest changes are now released, they are in v5.2.1 release.

Sorry for any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants