scout:import broken by this change!

[eminos]

0234cd8

[jasonbosco]

Sorry about the breakage and all the time-wasted :(

I've now rolled back the 5.2.0 release, and set 5.1.0 as the latest one.

CC: @arayiksmbatyan @karakhanyans

[karakhanyans]

Hi @eminos

We are currently investigating the problem, could you please give us more details about this problem, as we are not able to reproduce in our end.

We need your Laravel version, your PHP version.

Thanks.

[ricardo-lobo]

The problem is the usage of getDirty instead of getChanges

See https://github.com/laravel/framework/blob/78eb4dabcc03e189620c16f436358d41d31ae11f/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L1126

After a model is updated, getDirty will always return empty and it will not be updated to Typesense.

Using latest Laravel version and PHP 8.1

[eminos]

The problem is the usage of getDirty instead of getChanges

How would that help when artisan scout:import?
getChanges would, AFAIK, also return empty and thus not letting the typesense document import happen.

The issue seems to be that artisan scout:import is using that update method in TypesenseEngine.php and the PR "Reduce unnecessary API calls" doesn't address that.

[ricardo-lobo]

@eminos You are probably right. I haven't tested this to be sure. I noticed this yesterday because I have a test that checks if a product updated with certain fields is synced to Typesense.