Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transforming string to lowercase turns string object into [object object] on latest version 0.3.2 #560

Closed
abbasogaji opened this issue Jan 18, 2021 · 9 comments
Labels
status: invalid Issues with no action to take type: fix Issues describing a broken feature.

Comments

@abbasogaji
Copy link

Description

Minimal code-snippet showcasing the problem

Expected behavior

Actual behavior

@abbasogaji abbasogaji added status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature. labels Jan 18, 2021
@wafflesrg00d
Copy link

wafflesrg00d commented Jan 20, 2021

I'm seeing the same, @abbasogaji.

@Transform((value) => value.toString())

@uamanager
Copy link

Guys this is because breaking changes in patch version.
You can fix it like this:

// instead of this
@Transform((value) => value.toString())

// use object destruction as decorator pass object instead of list of arguments
@Transform(({value}) => value.toString())

@abbasogaji
Copy link
Author

@uamanager i thought breaking changes should roll out a major release, because this could affect a lot of projects

@uamanager
Copy link

@abbasogaji Contributors of this library thinking in another way) That's how they broke my production also))

@abbasogaji
Copy link
Author

@uamanager ...this is really bad.. I have quite lot of projects (microservices) in production using class-transformer , this is going to be a mess, now I have to make sure new deployments doesn't pick this version to avoid this issue

@uamanager
Copy link

@abbasogaji just fix version to 0.3.1 for now. that's the quickest way. and then update version and refactor code of microservices one by one.

@AckerApple
Copy link

572,670 Downloads a week but this package is claiming since in version 0 it still can have a party and do whatever it wants. The MINOR version should have at least been changed.

@NoNameProvided NoNameProvided added status: invalid Issues with no action to take type: fix Issues describing a broken feature. and removed status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature. labels Feb 14, 2021
@NoNameProvided
Copy link
Member

Working as intended, the signature has changed in 0.3.2. It has been deprecated and republished with some extra changes as 0.4.0.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: invalid Issues with no action to take type: fix Issues describing a broken feature.
Development

No branches or pull requests

5 participants