fix: pass context for isDefined and custom validators #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiangf
added a commit
to chiangf/class-validator
that referenced
this pull request
Dec 20, 2018
Since we need typestack#296 to be able to use context with isDefined, ran a `npm run-script build` and then moved all the files from build/package into the root, which mimics an npm published build. Also, we cannot simply add the branch to package.json because yarnpkg/yarn#1671
chiangf
force-pushed
the
isdefined-context
branch
from
5e622ea
to
78e1b30
Compare
chiangf
added a commit
to chiangf/class-validator
that referenced
this pull request
Dec 20, 2018
Since we need typestack#296 to be able to use context with isDefined, ran a `npm run-script build` and then moved all the files from build/package into the root, which mimics an npm published build. Also, we cannot simply add the branch to package.json because yarnpkg/yarn#1671
|
@amirsaber Would you be able to help review this? Thanks! |
|
just discovered this problem today, thanks for the PR ! |
|
When this will be merged and available on NPM :) ? |
|
Any update on this? |
|
Any update on this? Just bumped into this issue myself, would be handy if context on custom validators would be passed. |
|
I'm happy to resolve the conflicts, if someone is willing to review? |
|
Sure. Please resolve conflicts, cover changes with tests and I am happy to review this. |
Context wasn't being passed in for isDefined and custom validators. typestack#292
chiangf
force-pushed
the
isdefined-context
branch
from
73512b9
to
8d5c466
Compare
|
@vlapo should be ready for review, thanks! |
vlapo
suggested changes
Oct 26, 2019
vlapo
approved these changes
Oct 28, 2019
vlapo
changed the title
|
Thank you for your patient and perseverance. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context wasn't being passed in for isDefined and custom validators.
#292