feat: replace instanceof Promise and support Promise/A+ #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Jan 28, 2019
|
@NoNameProvided Would you be able to take a look at this please when you have time? Thanks |
|
I am ok with support Promise/A+ compliant thenable but why we need another dependency because of one function? Could you please create e.g. new |
|
@vlapo Done |
vlapo
suggested changes
Jul 24, 2019
There was a problem hiding this comment.
@andrewwa-kainos Thnx for your effort. Could you please check my in-code comment?
Note: We have also new ValidatePromise (merged it few moments ago). Could you rebase and also use your isPromise method in this validator?
vlapo
approved these changes
Jul 25, 2019
|
Thank you for your contribution :) |
vlapo
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem found wherein "Promise" instances from ES5 were not recognised as "instanceof Promise" from ES2015.