Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default message for isPort validator #404

Merged
merged 1 commit into from Aug 19, 2019
Merged

fix: add default message for isPort validator #404

merged 1 commit into from Aug 19, 2019

Conversation

rubiin
Copy link
Contributor

@rubiin rubiin commented Aug 19, 2019

isPort which was used to check whether a given number was actaully a port was missing the default message thrown in case of falsy values.

@vlapo vlapo changed the title added failure message for isPort fix: add default message for isPort validator Aug 19, 2019
@vlapo
Copy link
Contributor

vlapo commented Aug 19, 2019

Thank you :)

@vlapo vlapo merged commit 74e568c into typestack:master Aug 19, 2019
@rubiin
Copy link
Contributor Author

rubiin commented Aug 20, 2019

I would like to help out with other pull requests as wel

@vlapo
Copy link
Contributor

vlapo commented Aug 20, 2019

Sure check issues or milestones and create PRs :)

@rubiin
Copy link
Contributor Author

rubiin commented Aug 20, 2019

sure. On it

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants