Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to stop validation at first error #620

Merged

Conversation

ytetsuro
Copy link
Contributor

@ytetsuro ytetsuro commented May 27, 2020

Description

Added an option to not detect more than one Error for each item.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes (An error occurs outside of this PR.)
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

references #148, references #399, references #188

@molinab297-unisys
Copy link

If we could get this merged that would be awesome... #188 shows how much demand there is for this feature.

@NoNameProvided NoNameProvided changed the base branch from master to develop August 2, 2020 11:49
@ytetsuro ytetsuro force-pushed the fix/#399/add-stopAtFirstError-flag branch from 9b75f52 to f3cba6a Compare August 3, 2020 02:52
@ytetsuro
Copy link
Contributor Author

ytetsuro commented Aug 3, 2020

@NoNameProvided

A conflict was occurring, so I rebased it.

However, CI/CD is giving me an error at a point completely unrelated to this fix.
Does this need to be fixed in this PR?

@ytetsuro ytetsuro force-pushed the fix/#399/add-stopAtFirstError-flag branch from c57998c to dfd0159 Compare August 4, 2020 08:31
@ytetsuro ytetsuro changed the title add stop at first error option. feat: Add stop at first error option. Aug 4, 2020
Copy link
Member

@NoNameProvided NoNameProvided left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks good, added a few feedback.

src/validation/ValidatorOptions.ts Outdated Show resolved Hide resolved
test/functional/validation-options.spec.ts Outdated Show resolved Hide resolved
test/functional/validation-options.spec.ts Show resolved Hide resolved
@NoNameProvided NoNameProvided added the status: awaiting answer Awaiting answer from the author of issue or PR. label Aug 4, 2020
@NoNameProvided NoNameProvided changed the title feat: Add stop at first error option. feat: add option to stop validation at first error Aug 4, 2020
@ytetsuro ytetsuro force-pushed the fix/#399/add-stopAtFirstError-flag branch from a1b506c to 33fe1f1 Compare August 6, 2020 15:25
@NoNameProvided NoNameProvided merged commit ed53f14 into typestack:develop Aug 7, 2020
@NoNameProvided NoNameProvided removed the status: awaiting answer Awaiting answer from the author of issue or PR. label Aug 7, 2020
@ytetsuro
Copy link
Contributor Author

ytetsuro commented Aug 8, 2020

Thanks merged.

@github-actions
Copy link

github-actions bot commented Sep 8, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants