Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"options" in ValidationDecoratorOptions interface should be optional #66

Closed
christophercr opened this issue Feb 14, 2017 · 2 comments
Closed

"options" in ValidationDecoratorOptions interface should be optional #66

christophercr opened this issue Feb 14, 2017 · 2 comments

Comments

@christophercr
Copy link
Contributor

christophercr commented Feb 14, 2017 •
edited

Hi,

I'm using this awesome library in my project and now I enabled the strictNullChecks option from TS to have more explicit types. Then I noticed that the "options" property in the ValidationDecoratorOptions interface is required. However, digging a bit in the source code I noticed that it is used ValidationMetadata class but only if is defined. This class implements the corresponding ValidationMetadataArgs interface where indeed the "options" (alias "validationOptions") are optional.

Therefore I think that the "options" property should be marked as optional in the ValidationDecoratorOptions.

It's an easy and quick fix...
@christophercr christophercr mentioned this issue Feb 14, 2017
Merged
@christophercr
Copy link
Contributor Author

Hi, quick question... is there already a release containing this fix?

@pleerock
Copy link
Contributor

pleerock commented Apr 1, 2017

yes it should be there can you check latest version?

@typestack typestack locked and limited conversation to collaborators Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pleerock @NoNameProvided @christophercr