Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate error code 51 #157

Closed
Medvezo opened this issue Jun 22, 2019 · 1 comment · Fixed by #158
Closed

Deprecate error code 51 #157

Medvezo opened this issue Jun 22, 2019 · 1 comment · Fixed by #158
Labels
good first issue

Comments

@Medvezo
Copy link

Medvezo commented Jun 22, 2019

CURLE_PEER_FAILED_VERIFICATION was merged with CURLE_SSL_CACERT in 7.62: curl/curl#2901

Error code 51 was obsoleted: https://github.com/curl/curl/blob/ae99b4de1c443ae9892b1c0fc2b39e3afe73c4bc/include/curl/curl.h

However, typhoeus still returns ssl_cacert code:

ethon/lib/ethon/curls/codes.rb

Line 72 in de60a72

:ssl_cacert,

@PericlesTheo
Copy link
Member

Thanks for the heads up. I will mark it as good first issue and pass it on to someone

@arku arku mentioned this issue Oct 3, 2019
Merged
PericlesTheo added a commit that referenced this issue Oct 3, 2019
@PericlesTheo
Merge pull request #158 from arku/chore/ssl_cacert-removal
8f9c711 
Remove ssl_cacert from return codes

`CURLE_PEER_FAILED_VERIFICATION` was merged with `CURLE_SSL_CACERT`.  See #157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ssl_cacert from return codes arku/ethon
2 participants
@PericlesTheo @Medvezo