You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing #507, I was bit by this the other day and thought I'd make the suggested change to raise a meaningful error. I also added some documentation about this to the README. Let me know what you think.
I tried looking at the Travis failures. For MRI 1.8.7 I needed to bundle locally with CI=1 bundle install because guard-rspec requires a celluloid version that requires newer Ruby, and then CI=1 bundle exec rake (yeah, I could've just exported CI). But then the tests pass. The error on Travis is a segfault, and I guess could just be 1.8.7 craziness.
On the jruby-1.8.7 side I had fewer hassles running locally, but running the failing test (rspec ./spec/typhoeus/pool_spec.rb:90) revealed that it fails intermittently, around 40% of the time. The same is true on master.
I must admit I'm surprised that this gem continues to support 1.8.7 😉
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referencing #507, I was bit by this the other day and thought I'd make the suggested change to raise a meaningful error. I also added some documentation about this to the README. Let me know what you think.