Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating form_params to json #82

Merged
merged 2 commits into from Sep 14, 2020

Conversation

eporama
Copy link
Contributor

@eporama eporama commented Sep 9, 2020

This is a PR to fix #81

@coveralls
Copy link

coveralls commented Sep 9, 2020

Coverage Status

Coverage decreased (-0.01%) to 99.068% when pulling e07e4de on eporama:81-x-www-form-encoded-to-json into 28e88b5 on typhonius:master.

@typhonius
Copy link
Owner

Thanks @eporama for the deep dive into this. One question - do you think that based on this behaviour we need some kind of test for encoding and content-type or would this be covered by Guzzle's tests?

@eporama
Copy link
Contributor Author

eporama commented Sep 10, 2020

I don't know that we would… I'm not sure that it's any more testable than using form_params was… but I could be wrong on that. I'm learning a lot about these things today…

@typhonius
Copy link
Owner

Thanks for that, I'll have a peek over the next couple of days to see if I can add anything else here - if not I'll merge.

@typhonius
Copy link
Owner

Looking at this again, we already check that json (not form_params) are within the options array passed to Guzzle so I'm happy to not include any additional tests (since it should be covered in Guzzle).

@typhonius typhonius merged commit 4451a51 into typhonius:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using x-www-form-urlencoded is untyped and causes issues with api backend validation
3 participants