Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not perform DB backup during the "code:switch" task until explicitly requested #69

Closed
aroq opened this issue Apr 4, 2020 · 2 comments

Comments

@aroq
Copy link

aroq commented Apr 4, 2020

Is your feature request related to a problem? Please describe.
Backup is performed during the code:switch task which is not suitable for all cases, e.g. performing a deployment to the PREPROD environment with a lot of huge DBs or delivering an urgent hot-fix to the PRODUCTION environment.

Describe the solution you'd like
Do not perform DB backup during the code:switch task until explicitly requested with an additional option.

Describe alternatives you've considered
Create an option to switch off the backup task (to keep the code:switch workflow backward-compatible).

@typhonius
Copy link
Owner

Thanks for this, I think the best option here would be to provide an option to code:switch and code:deploy that allows users to avoid the backup. I won't change the default as it may have negative effects on other users who are anticipating a backup to coincide with code tasks.

@aroq
Copy link
Author

aroq commented Apr 5, 2020

Thank you, works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants