Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages that use pinst are broken when they are installed with npm 10.4.0 and later #23

Closed
djcsdy opened this issue Mar 28, 2024 · 5 comments

Comments

@djcsdy
Copy link

djcsdy commented Mar 28, 2024

Hello.

Just a heads up that npm 10.4.0 and later seem to have broken pinst. It seems that npm 10.4.0 runs scripts named _postinstall after package installation exactly as if they were named postinstall.

This seems to be a bug in npm, but I am reporting it here for visibility. See npm/cli#7322.

@typicode
Copy link
Owner

Thanks for letting me know! I hope it'll get resolved soon.

@typicode
Copy link
Owner

It should have a low impact as pinst is useful for yarn in particular

@djcsdy
Copy link
Author

djcsdy commented Mar 29, 2024

Unfortunately the problem occurs at package installation time, so it affects packages built with yarn if the end user installs them with npm.

Some of my packages use yarn and pinst, and if you install those packages as a dependency in another project with npm 10.4.0+, then npm will try to run the _postinstall script, and either fail or do something stupid.

@typicode
Copy link
Owner

You're right, didn't see things from this point

@djcsdy
Copy link
Author

djcsdy commented Apr 19, 2024

Hi @typicode. The above description of this problem is not accurate, but there is a problem you ought to know about.

I've emailed you privately about this for reasons that will become apparent when you read the email. Please be on the lookout for an email from mail@danielcassidy.me.uk.

Closing this issue for now.

@djcsdy djcsdy closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants