Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Enable caching for GH Actions #1002

Merged
merged 4 commits into from Jul 21, 2021
Merged

[TASK] Enable caching for GH Actions #1002

merged 4 commits into from Jul 21, 2021

Conversation

gilbertsoft
Copy link
Contributor

@gilbertsoft gilbertsoft commented Jul 21, 2021 •
edited

@gilbertsoft gilbertsoft marked this pull request as draft July 21, 2021 10:07
@gilbertsoft gilbertsoft marked this pull request as ready for review July 21, 2021 10:17
@gilbertsoft gilbertsoft requested a review from helhum July 21, 2021 10:17
helhum
helhum requested changes Jul 21, 2021
View reviewed changes
Copy link
Member

@helhum helhum left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in Analyze.yml caches could be added as well.
Oh and in the Consistency job in Test.yml Composer is involved as well, so caches would be beneficial there, too

.github/workflows/Deploy.yml Outdated Show resolved Hide resolved
.github/workflows/Test.yml Show resolved Hide resolved
.github/workflows/Test.yml Outdated Show resolved Hide resolved
@gilbertsoft
Copy link
Contributor Author

gilbertsoft commented Jul 21, 2021 •
edited

Oh and in the Consistency job in Test.yml Composer is involved as well, so caches would be beneficial there, too

Not sure if there is a composer update or install involved here. If not caching does not make sense imho....

Just saw composer extension-release calls composer update so will add it...

@gilbertsoft gilbertsoft requested a review from helhum July 21, 2021 13:11
@helhum
Copy link
Member

helhum commented Jul 21, 2021

Thanks!

@helhum helhum merged commit 2a0dea9 into TYPO3-Console:latest Jul 21, 2021
@helhum helhum deleted the task/enable-ci-cache branch July 21, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helhum helhum helhum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gilbertsoft @helhum