New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Make it work again with TYPO3 10.x (only in 6.x branch) #1045
Conversation
@helhum please take a look if you agree with this backport, since else we would have to start using a fork in our TYPO3 v10 installations. If merged, would you be so kind to make a "last" v6.6.1 release? Thanks a lot for your endless effort on this front! |
Ok tests are now (still) failing, because TYPO3 core also updated symfony/console. Updated in https://get.typo3.org/release-notes/11.5.6 and https://get.typo3.org/release-notes/10.4.13 And also Tried to fix the tests with this, lets see... Tests are not running anymore, could you "approve run the workflow" please @helhum ? |
Ok, the problem is now that TYPO3-console 6.x is not really compatible with TYPO3 11.5:
So my suggestion would be to mark 6.x as only compatible with TYPO3 10, remove all TYPO3 11 tests, and release that as a "6.7.0". Then installations with TYPO3 v10 can at least still use console 6.7.0 while TYPO3 v11 users can update to 7.0.5. What do you think @helhum. And could I do that finishing cleanup in this pull request too? |
Thanks Ernesto for digging into this. Highly appreciated.
Sure it is not. It is marked compatible with
What is the issue with TYPO3 11.3 with this change? I did not look into the details.
I'd say make the change as small as possible, but as big as necessary :) |
Supporting "older TYPO3 v11" (i.e 11.3) would require to support symfony/console 5.3 while newer TYPO3 v11.5 comes with symfony/console 5.4. But I saw your comments about removing 11.x support altogether, so I'll do that now. |
The callback interface change was introduced in TYPO3 10.4.22 and 11.5.2.
338e4e4
to
a466059
Compare
Thanks Ernesto! |
dev-master
or TYPO3 v11Resolves #1043