Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Make it work again with TYPO3 10.x (only in 6.x branch) #1045

Merged
merged 2 commits into from Apr 10, 2022

Conversation

baschny
Copy link

@baschny baschny commented Apr 6, 2022

  • Make branch 6.x work again with TYPO3 v10 (by backporting fix [BUGFIX] Add type hints to callback implementation #1026 from 7.x to 6.x)
  • Drop support for TYPO3 v11 in 6.x branch (use typo3-console 7.x instead)
  • Make tests run again by fixing TYPO3 core version constraints:
    • minimum required TYPO3 v10.4.22
    • no longer test for dev-master or TYPO3 v11

Resolves #1043

@baschny
Copy link
Author

baschny commented Apr 6, 2022

@helhum please take a look if you agree with this backport, since else we would have to start using a fork in our TYPO3 v10 installations. If merged, would you be so kind to make a "last" v6.6.1 release? Thanks a lot for your endless effort on this front!

@baschny
Copy link
Author

baschny commented Apr 6, 2022

Ok tests are now (still) failing, because TYPO3 core also updated symfony/console. Updated in https://get.typo3.org/release-notes/11.5.6 and https://get.typo3.org/release-notes/10.4.13

And also dev-master is now too large version for 6.x branch.

Tried to fix the tests with this, lets see... Tests are not running anymore, could you "approve run the workflow" please @helhum ?

@baschny
Copy link
Author

baschny commented Apr 6, 2022

Ok, the problem is now that TYPO3-console 6.x is not really compatible with TYPO3 11.5:

❯ ./typo3cms commandreference:render

                                                                               
  [ TYPO3\CMS\Core\Console\CommandNameAlreadyInUseException ]                  
  Command "extension:setup" registered by "extension:setup" is already in use  

So my suggestion would be to mark 6.x as only compatible with TYPO3 10, remove all TYPO3 11 tests, and release that as a "6.7.0".

Then installations with TYPO3 v10 can at least still use console 6.7.0 while TYPO3 v11 users can update to 7.0.5.

What do you think @helhum. And could I do that finishing cleanup in this pull request too?

@helhum
Copy link
Member

helhum commented Apr 6, 2022

Thanks Ernesto for digging into this. Highly appreciated.

Ok, the problem is now that TYPO3-console 6.x is not really compatible with TYPO3 11.5:

Sure it is not. It is marked compatible with >=11.3.1 <11.4.0

So my suggestion would be to mark 6.x as only compatible with TYPO3 10, remove all TYPO3 11 tests, and release that as a "6.7.0".

What is the issue with TYPO3 11.3 with this change? I did not look into the details.

Then installations with TYPO3 v10 can at least still use console 6.7.0 while TYPO3 v11 users can update to 7.0.5.
What do you think @helhum. And could I do that finishing cleanup in this pull request too?

I'd say make the change as small as possible, but as big as necessary :)

Resources/Private/ExtensionArtifacts/composer.json Outdated Show resolved Hide resolved
Resources/Private/ExtensionArtifacts/ext_emconf.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
@baschny
Copy link
Author

baschny commented Apr 6, 2022

Supporting "older TYPO3 v11" (i.e 11.3) would require to support symfony/console 5.3 while newer TYPO3 v11.5 comes with symfony/console 5.4.

But I saw your comments about removing 11.x support altogether, so I'll do that now.

@baschny baschny requested a review from helhum April 6, 2022 17:05
@baschny baschny changed the title [BUGFIX] Add type hints to callback implementation (backport to 6.x) [BUGFIX] Make it work again with TYPO3 10.x (only in 6.x branch) Apr 6, 2022
The callback interface change was introduced in TYPO3 10.4.22 and 11.5.2.
@helhum
Copy link
Member

helhum commented Apr 10, 2022

Thanks Ernesto!

@helhum helhum merged commit ec4db7a into TYPO3-Console:6.x Apr 10, 2022
@baschny baschny deleted the 6.x-1043-finediff branch April 10, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants