[TASK] Provide basic compatibility with TYPO3 v12 #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds basic functionality for TYPO3 v12. Support for TYPO3 v12 was provided by using "Typo3Version" with a few switches regarding Doctrine DBAL 3.x support and Bootstrap (PageRenderer::setCache is not needed anymore). Manual tests executed with TYPO3 v12: * install:setup * backend:createadmin * upgrade:prepare
SIRprise
previously approved these changes
Nov 29, 2022
baschny
previously approved these changes
Feb 10, 2023
|
@baschny thanks for the heads up. If tests for 11 are green, I'll merge this, so that TYPO3 Console dev-main can be installed with TYPO3 dev-main. Still use at own risk, but if this helps, I'll gladly provide that. |
helhum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds basic functionality for TYPO3 v12.
By using TYPO3 v12 the main issue is providing
compatibility with symfony 6.
This means, that all *Command->execute() methods
need the return type "int" added. Similar
logic applies to "isHidden(): bool".
In addition, various helper functions need
to have their return type added.
The "Helper::strlen()" was deprecated in Symfony 5.3 and removed in Symfony 6. The replacement is
"Helper::width()" which is solved by using
a helper class to support both Symfony 4+6.
Support for TYPO3 v12 was provided by using
"Typo3Version" with a few switches regarding
Doctrine DBAL 3.x support and Bootstrap
(PageRenderer::setCache is not needed anymore).
Manual tests executed with TYPO3 v12: