[BUGFIX] Improve error and exception handling #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helhum
force-pushed
the
improve-error-handling
branch
from
7238f86
to
7e8c683
Compare
Previously we ignored all TYPO3 configuration regarding error and exception handling, to get a more reliable behavior and a decent error output. With this change we loosen this strictness a bit and at least look at the configured error levels that should be logged or turned into exceptions, but still enforce a reasonable configuration, by not allowing warnings to be omitted. Additionally we make sure both exceptions and errors are properly logged using the logging framework. We still disallow changing the error and exception handler to disallow misconfiguration and also still not log errors to the legacy database log. In case the latter is needed, it would still be possible to create a writer, that writes to the database in a way that the TYPO3 backend log module can use it.
Skip the deprecation message regarding old command registration in early boot for TYPO3 8.7 installations, to allow users to more easily use the latest console version with that older TYPO3 version. Still nag people when using TYPO3 9.5 though, as Symfony Commands are available since TYPO3 8.7, which means enough grace time to switch.
helhum
force-pushed
the
improve-error-handling
branch
from
7e8c683
to
88d8614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we ignored all TYPO3 configuration regarding
error and exception handling, to get a more reliable behavior
and a decent error output.
With this change we loosen this strictness a bit and at least look
at the configured error levels that should be logged or turned
into exceptions, but still enforce a reasonable configuration, by not
allowing warnings to be omitted.
Additionally we make sure both exceptions and errors are properly logged
using the logging framework.
We still disallow changing the error and exception handler to disallow
misconfiguration and also still not log errors to the legacy database log.
In case the latter is needed, it would still be possible to create a writer,
that writes to the database in a way that the TYPO3 backend log module
can use it.