[TASK] Migrate DatabaseCommandController to Symfony Commands #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbertsoft
force-pushed
the
sf-database
branch
5 times, most recently
from
b029faf
to
55ba84b
Compare
gilbertsoft
force-pushed
the
sf-database
branch
from
55ba84b
to
ae5f2ee
Compare
gilbertsoft
changed the title
gilbertsoft
force-pushed
the
sf-database
branch
from
ae5f2ee
to
80f1617
Compare
mbrodala
reviewed
Sep 30, 2019
|
Thanks for creating all these pull requests 😍
I'd like to do deprecation removal and streamlining a different task. Thanks! |
helhum
requested changes
Sep 30, 2019
gilbertsoft
force-pushed
the
sf-database
branch
from
80f1617
to
2a2676d
Compare
|
consts are removed now, restore of removal of deprecations still pending... |
gilbertsoft
force-pushed
the
sf-database
branch
from
2a2676d
to
e88bc46
Compare
|
Removals are restored now |
gilbertsoft
force-pushed
the
sf-database
branch
from
e88bc46
to
ecddd47
Compare
gilbertsoft
changed the title
gilbertsoft
force-pushed
the
sf-database
branch
from
ecddd47
to
d2b634a
Compare
helhum
requested changes
Sep 30, 2019
|
|
||
| $objectManager = GeneralUtility::makeInstance(ObjectManager::class); | ||
| $this->connectionConfiguration = $connectionConfiguration | ||
| ?? $objectManager->get(ConnectionConfiguration::class); |
There was a problem hiding this comment.
using the object manager here is unnecessary and counter productive.
please keep using new, like in DatabaseExportCommand
|
|
||
| class DatabaseExportCommand extends AbstractConvertedCommand |
There was a problem hiding this comment.
please keep this already converted command unchanged. thanks.
The following commands are migrated from a CommandController structure to Symfony Commands: - database:export - database:import - database:updateschema
helhum
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commands are migrated from a CommandController structure
to Symfony Commands: