Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Use correct binary in non-composer mode on Windows #969

Merged
merged 1 commit into from Mar 5, 2021

Conversation

IchHabRecht
Copy link
Contributor

No description provided.

@mbrodala
Copy link
Contributor

What's the issue with the current setup? The mentioned typo3cms script includes the one in Scripts so technically there shouldn't be a difference ...

@helhum
Copy link
Member

helhum commented Feb 24, 2021

@mbrodala the built extension does not have this file any more, therefore the bat file fails

@IchHabRecht
Copy link
Contributor Author

Hi @mbrodala,

Additionally to @helhum information: there is some code that checks for an application name e.g. Classes/Console/Mvc/Cli/CommandDispatcher.php:95 that expects the name to match typo3cms and doesn't allow any php file.

@mbrodala
Copy link
Contributor

I see, thanks. :-)

@helhum helhum merged commit 5e074a2 into TYPO3-Console:latest Mar 5, 2021
@IchHabRecht IchHabRecht deleted the fix-windows-non-composer branch March 16, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants