Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache:flush --force truncates realurl data tables #327

Closed
frans-beech-it opened this issue Oct 20, 2016 · 12 comments
Closed

cache:flush --force truncates realurl data tables #327

frans-beech-it opened this issue Oct 20, 2016 · 12 comments

Comments

@frans-beech-it
Copy link
Contributor

The cache:flush --force command truncates all realurl tables but these are not all "cache" tables since realurl 2 (https://github.com/dmitryd/typo3-realurl/)
For realurl >= 2.1 these are already renamed tx_realurl_*cache to tx_realurl_*data

@helhum
Copy link
Member

helhum commented Oct 20, 2016

This will be solved with #286 implemented, because realurl registers datahandler hooks

@mbrodala
Copy link
Contributor

Notice that --force currently enforces flushing of tables beginning with tx_realurl_ except of tx_realurl_redirects, thus the change in RealURL won't help here.

@frans-beech-it
Copy link
Contributor Author

also tx_realurl_uniqalias is removed

working on a PR

@frans-beech-it
Copy link
Contributor Author

@helhum do you want to keep the || ($tableName !== 'tx_realurl_redirects'.... in forceFlushCoreFileAndDatabaseCaches()? Don't think this belongs here at all

There are current 2 solutions exclude tx_realurl_*data and tx_realurl_uniqalias in forceFlushCoreFileAndDatabaseCaches() or remove the tx_realurl... exclude. #286 will bring back this probably then

@helhum
Copy link
Member

helhum commented Oct 20, 2016

do you want to keep the || ($tableName !== 'tx_realurl_redirects'.... in forceFlushCoreFileAndDatabaseCaches()

absolutely not! 083b34c was implemented as temporary solution, which exists already for too long now

@helhum
Copy link
Member

helhum commented Oct 20, 2016

thus the change in RealURL won't help here.

change in realurl? My idea is to call all clear cache hook subscribers in console. nothing to do in realurl

@mbrodala
Copy link
Contributor

mbrodala commented Oct 20, 2016

@helhum I was referring to this:

For realurl >= 2.1 these are already renamed tx_realurl_*cache to tx_realurl_*data

Thus even with RealURL 2.1 and later the tables will be flushed, no matter the suffix.

@frans-beech-it
Copy link
Contributor Author

@helhum so we remove it now or "temporary" change is to only truncate the tx_realurl_*cache tables?

@helhum
Copy link
Member

helhum commented Oct 20, 2016

Idea is to remove the realurl tables hack there completely and call this hook https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L8217-L8222 with a fake datahandler in the service instead

@frans-beech-it
Copy link
Contributor Author

But that will not be backported to the 3.x branch right?

@helhum
Copy link
Member

helhum commented Oct 20, 2016

But that will not be backported to the 3.x branch right?

Of course it will

helhum added a commit that referenced this issue Oct 20, 2016
Especially with realurl 2.x available, the workaround cleared
too many realurl tables, which may lead to a broken data state.

Fixes #327
Fixes #328
@helhum
Copy link
Member

helhum commented Oct 20, 2016

please review #329 thanks!

@helhum helhum closed this as completed in 32ca8e6 Oct 21, 2016
helhum added a commit that referenced this issue Oct 25, 2016
Especially with realurl 2.x available, the workaround cleared
too many realurl tables, which may lead to a broken data state.

Fixes #327
Fixes #328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants