Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow "--opt" for database:export #701

Closed
koehnlein opened this issue May 3, 2018 · 1 comment
Closed

Allow "--opt" for database:export #701

koehnlein opened this issue May 3, 2018 · 1 comment

Comments

@koehnlein
Copy link

Q A
Bug report? no
Feature request? yes
TYPO3 version all
TYPO3 Console version all
TYPO3 Composer mode? both

A very well known TYPO3 hoster requires mysqldump executed with attribute --opt to keep the correct charset. (See this support message on Twitter: https://twitter.com/jweilandnet/status/913397108853678080)

It would be great, if your awesome TYPO3 console would offer a way to set this parameter for the database:export command.
@helhum
Copy link
Member

helhum commented May 3, 2018

A mysqldump --help on a jweiland server gives me:

  --opt               Same as --add-drop-table, --add-locks, --create-options,
                      --quick, --extended-insert, --lock-tables, --set-charset,
                      and --disable-keys. Enabled by default, disable with
                      --skip-opt.

So my question would be, why --opt should be added, if it is default.

helhum added a commit to helhum/TYPO3-Console that referenced this issue May 3, 2018
@helhum
[BUGFIX] Ensure charset info is put in DB dump
2f86e84 
To ensure the correct charset for database dumps,
we now use --opt as argument (which adds --set-charset).

Since we want to use --single-transaction, we explicitly
disable table locking with --skip-lock-tables

Fixes: TYPO3-Console#701
@helhum helhum mentioned this issue May 3, 2018
Merged
helhum added a commit to helhum/TYPO3-Console that referenced this issue May 8, 2018
@helhum
[BUGFIX] Ensure charset info is put in DB dump
2b9b02f 
To ensure the correct charset for database dumps,
we now use --opt as argument (which adds --set-charset).

Since we want to use --single-transaction, we explicitly
disable table locking with --skip-lock-tables

Fixes: TYPO3-Console#701
helhum added a commit to helhum/TYPO3-Console that referenced this issue May 12, 2018
@helhum
[BUGFIX] Ensure charset info is put in DB dump
18bc542 
To ensure the correct charset for database dumps,
we now use --opt as argument (which adds --set-charset).

Since we want to use --single-transaction, we explicitly
disable table locking with --skip-lock-tables

Fixes: TYPO3-Console#701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helhum @koehnlein