-
Notifications
You must be signed in to change notification settings - Fork 653
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[TASK] Simplify API for checking link target
Previously, the function BrokenLinkRepository::getNumberOfBrokenLinks() was used in the event listener. It is not necessary to return the count. We now only check if the link target is in the list of broken links. This makes the API easier to read and reduces the number of methods with similar and misleading names. Resolves: #90390 Releases: master Change-Id: Ia94a7a0bd44bbc827864371f7c6694b4b8f8f52a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63267 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
- Loading branch information
1 parent
7091f48
commit 41d7cee
Showing
3 changed files
with
69 additions
and
5 deletions.
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
...on-90390-DeprecateBrokenLinkRepositorygetNumberOfBrokenLinksInLinkvalidator.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
.. include:: ../../Includes.txt | ||
|
||
=============================================================================================== | ||
Deprecation: #90390 - Deprecate BrokenLinkRepository::getNumberOfBrokenLinks() in linkvalidator | ||
=============================================================================================== | ||
|
||
See :issue:`90390` | ||
|
||
Description | ||
=========== | ||
|
||
The method :php:`BrokenLinkRepository::getNumberOfBrokenLinks()` is deprecated. | ||
|
||
|
||
Impact | ||
====== | ||
|
||
If third party extensions use this function, a `E_USER_DEPRECATED` | ||
is triggered. | ||
|
||
|
||
Affected Installations | ||
====================== | ||
|
||
This only affects third party extensions which use this function. The | ||
deprecated function is no longer used in the core. | ||
|
||
|
||
Migration | ||
========= | ||
|
||
Use :php:`BrokenLinkRepository::getNumberOfBrokenLinks()` instead. | ||
|
||
.. index:: Backend, NotScanned, ext:linkvalidator |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters