Skip to content

Commit

Permalink
[BUGFIX] Re-align IRRE header fields for FAL elements
Browse files Browse the repository at this point in the history
The IRRE header block of each element (such as "filename" and "title")
renders a "dl" as block as "dl-horizontal" was removed in Bootstrap 4.

This change changes the styling and markup to utilize the
Bootstrap 5 grid structure.

Resolves: #94485
Releases: master
Change-Id: I65542e0d32812a31be883d07701473061e5d3e0c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69720
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Benni Mack <benni@typo3.org>
  • Loading branch information
bmack committed Jul 12, 2021
1 parent 6141e85 commit 4e88508
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions Build/Sources/Sass/typo3/_main_form.scss
Expand Up @@ -378,9 +378,9 @@ select {
white-space: normal;
padding-left: 5px;

dl {
@extend .dl-horizontal;

dl,
dd,
dt {
margin-bottom: 0;
}
}
Expand Down
2 changes: 1 addition & 1 deletion typo3/sysext/backend/Resources/Public/Css/backend.css

Large diffs are not rendered by default.

Expand Up @@ -78,9 +78,9 @@ public function getInlineLabel(array &$params)
if ((string)$value === '') {
continue;
}
$labelText = (string)LocalizationUtility::translate('LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.' . $field, 'lang');
$title[] = '<dt>' . htmlspecialchars($labelText) . '</dt><dd>' . $value . '</dd>';
$labelText = (string)LocalizationUtility::translate('LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.' . $field);
$title[] = '<dt class="col-md-1 text-truncate">' . htmlspecialchars($labelText) . '</dt><dd class="col-md-11">' . $value . '</dd>';
}
$params['title'] = '<dl>' . implode('', $title) . '</dl>';
$params['title'] = '<dl class="row g-0">' . implode('<div class="w-100"></div>', $title) . '</dl>';
}
}

0 comments on commit 4e88508

Please sign in to comment.