Skip to content

Commit

Permalink
[TASK] Fail acceptance tests on JavaScript errors in browser console
Browse files Browse the repository at this point in the history
Raise typo3/testing-framework to 3.3.0

composer update typo3/testing-framework

Acceptance tests are configured to fail if JavaScript
errors are raised in the console.
See https://github.com/TYPO3/testing-framework/blob/master/Resources/Core/
Build/Configuration/Acceptance/Support/Helper/Acceptance.php

This commit also fixeds a bug found by the tests.
A requireJS error was thrown - timeout on loading `nprogress`
from within Loader.js.

Resolves: #84322
Releases: master
Change-Id: Iea9b6e0c435a73be6e6a4f9567d09f35880822ab
Reviewed-on: https://review.typo3.org/56196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
  • Loading branch information
tmotyl committed Mar 16, 2018
1 parent 9aa6349 commit 6b784dc
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 13 deletions.
10 changes: 5 additions & 5 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -12,19 +12,16 @@
*/

import {ScaffoldIdentifierEnum} from '../Enum/Viewport/ScaffoldIdentifier';
import NProgress = require('nprogress');

class Loader {
public static start(): void {
require(['nprogress'], (NProgress: NProgressStatic): void => {
NProgress.configure({parent: ScaffoldIdentifierEnum.contentModule, showSpinner: false});
NProgress.start();
});
NProgress.configure({parent: ScaffoldIdentifierEnum.contentModule, showSpinner: false});
NProgress.start();
}

public static finish(): void {
require(['nprogress'], (NProgress: NProgressStatic): void => {
NProgress.done();
});
NProgress.done();
}
}

Expand Down
Expand Up @@ -10,4 +10,4 @@
*
* The TYPO3 project - inspiring people to share!
*/
define(["require","exports","../Enum/Viewport/ScaffoldIdentifier"],function(n,t,e){"use strict";return function(){function t(){}return t.start=function(){n(["nprogress"],function(n){n.configure({parent:e.ScaffoldIdentifierEnum.contentModule,showSpinner:!1}),n.start()})},t.finish=function(){n(["nprogress"],function(n){n.done()})},t}()});
define(["require","exports","../Enum/Viewport/ScaffoldIdentifier","nprogress"],function(n,e,t,r){"use strict";return function(){function n(){}return n.start=function(){r.configure({parent:t.ScaffoldIdentifierEnum.contentModule,showSpinner:!1}),r.start()},n.finish=function(){r.done()},n}()});

0 comments on commit 6b784dc

Please sign in to comment.