[BUGFIX] Properly encode context menu URL parameters

Especially the "uid" might contain special characters as it holds the combined identifier in case of e.g. folders. Encoding this value is therefore necessary to prevent JS errors on executing the corresponding AJAX request. Resolves: #99893 Releases: main, 11.5 Change-Id: I6f00a23a34497b65f2ed915f76f1e40b3699792a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77884 Tested-by: core-ci <typo3@b13.com> Tested-by: Oliver Bartsch <bo@cedev.de> Reviewed-by: Oliver Bartsch <bo@cedev.de>
TYPO3 · Feb 16, 2023 · 74d2ab6 · 74d2ab6
1 parent 97706f2
commit 74d2ab6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenu.ts b/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenu.ts
@@ -125,10 +125,10 @@ class ContextMenu {
       parameters += 'table=' + encodeURIComponent(table);
     }
     if (typeof uid !== 'undefined') {
-      parameters += (parameters.length > 0 ? '&' : '') + 'uid=' + uid;
+      parameters += (parameters.length > 0 ? '&' : '') + 'uid=' + (typeof uid === 'number' ? uid : encodeURIComponent(uid));
     }
     if (typeof context !== 'undefined') {
-      parameters += (parameters.length > 0 ? '&' : '') + 'context=' + context;
+      parameters += (parameters.length > 0 ? '&' : '') + 'context=' + encodeURIComponent(context);
     }
     if (typeof enDisItems !== 'undefined') {
       parameters += (parameters.length > 0 ? '&' : '') + 'enDisItems=' + enDisItems;

diff --git a/typo3/sysext/backend/Resources/Public/JavaScript/ContextMenu.js b/typo3/sysext/backend/Resources/Public/JavaScript/ContextMenu.js