Skip to content

Commit

Permalink
[TASK] Correct QuerySettingsInterface RespectSysLanguage comments
Browse files Browse the repository at this point in the history
The setRespectSysLanguage and getRespectSysLanguage methods
are not ifluencing the overlay process, just whether to take
record language into account in db query.

Releases: master, 8.7
Resolves: #84419
Change-Id: I976210663b24ad99080daedea300c4e42ff59224
Reviewed-on: https://review.typo3.org/56290
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
tmotyl authored and lolli42 committed Mar 17, 2018
1 parent 1562fed commit 88706b7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
Expand Up @@ -52,18 +52,19 @@ public function setStoragePageIds(array $storagePageIds);
public function getStoragePageIds();

/**
* Sets the flag if a translation is chosen and language overlay should be performed.
* Sets the flag if record language should be respected when querying.
* Other settings defines whether overlay should happen or not.
*
* @param bool $respectSysLanguage TRUE if a translation is chosen and language overlay should be performed.
* @param bool $respectSysLanguage TRUE if only record language should be respected when querying
* @return \TYPO3\CMS\Extbase\Persistence\Generic\QuerySettingsInterface instance of $this to allow method chaining
* @api
*/
public function setRespectSysLanguage($respectSysLanguage);

/**
* Returns the state, if a language overlay should be performed when a translation is active.
* Returns the state, if record language should be checked when querying
*
* @return bool TRUE, if a language overlay should be performed when a translation is active; otherwise FALSE.
* @return bool if TRUE record language is checked.
*/
public function getRespectSysLanguage();

Expand Down
Expand Up @@ -86,7 +86,7 @@ class Typo3QuerySettings implements QuerySettingsInterface
protected $languageMode = null;

/**
* Represensting sys_language_uid only valid for current context
* Representing sys_language_uid only valid for current context
*
* @var int
*/
Expand Down

0 comments on commit 88706b7

Please sign in to comment.