Skip to content

Commit

Permalink
[TASK] Exclude StringClassNameToClassConstantRector in rector.yml
Browse files Browse the repository at this point in the history
As the StringClassNameToClassConstantRector would convert
string class names that are deliberately defined as string,
this rector has been disabled.

Releases: master
Resolves: #89899
Change-Id: Iecbcf2c009885501b0caafe66cb8f5703688c188
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62581
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
  • Loading branch information
alexanderschnitzler authored and georgringer committed Dec 10, 2019
1 parent 7999cae commit b106b3d
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions rector.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
services:
# php55
Rector\Php55\Rector\String_\StringClassNameToClassConstantRector:
$classesToSkip:
- Error
- Locale
- mysqli

parameters:
php_version_features: '7.2'
auto_import_names: false
Expand All @@ -21,7 +13,9 @@ parameters:
- 'typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/PropertyExistsStaticMatcherFixture.php'
- 'ClassAliasMap.php'
- 'class.ext_update.php'
exclude_rectors:
- Rector\Php55\Rector\String_\StringClassNameToClassConstantRector
sets:
- 'php53'
- 'php54'
# - 'php55' # disabled and configured manually via services.
- 'php55'

0 comments on commit b106b3d

Please sign in to comment.