[BUGFIX] Correctly resolve arrays in log messages

When using an array as data for a log entry placeholder, it must be imploded as otherwise the placeholder would not be resolved by AbstractWriter->interpolate(). Additionally, the exception is now correctly added to the log message string in PhpErrorLogWriter again. Resolves: #94594 Related: #94315 Releases: master Change-Id: I0aa79e511fd164a75e974547057477479234c25b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69978 Tested-by: core-ci <typo3@b13.com> Tested-by: Benni Mack <benni@typo3.org> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
TYPO3 · Jul 22, 2021 · bcb5090 · bcb5090
1 parent 7970143
commit bcb5090
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php b/typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php
@@ -726,7 +726,7 @@ protected function getAuthServices(string $subType, array $loginData, array $aut
         if (!empty($serviceChain)) {
             $this->logger->debug('{subtype} auth services called: {chain}', [
                 'subtype' => $subType,
-                'chain' => $serviceChain,
+                'chain' => implode(',', $serviceChain),
             ]);
         }
     }

diff --git a/typo3/sysext/core/Classes/Log/Writer/PhpErrorLogWriter.php b/typo3/sysext/core/Classes/Log/Writer/PhpErrorLogWriter.php
@@ -48,7 +48,7 @@ public function writeLog(LogRecord $record)
             strtoupper($record->getLevel()),
             $record->getRequestId(),
             $record->getComponent(),
-            $this->interpolate($record->getMessage(), $context),
+            $this->interpolate($message, $context),
             $data
         );
         if (false === error_log($message)) {

diff --git a/typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php b/typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php
@@ -345,7 +345,7 @@ public function createUserAspect(bool $respectUserGroups = true): UserAspect
             $this->updateOnlineTimestamp();
         }
 
-        $this->logger->debug('Valid frontend usergroups: {groups}', ['groups' => $userGroups]);
+        $this->logger->debug('Valid frontend usergroups: {groups}', ['groups' => implode(',', $userGroups)]);
         return GeneralUtility::makeInstance(UserAspect::class, $this, $userGroups);
     }
     /**