[TASK] Improve "Active Typoscript" view

The module receives a similar treatment as
"Active PageTsConfig", namely client side
search and client side expand state persisting.

This simplifies server side a bit, which is
cleaned up. We're also avoiding the naming
'object browser' in file names and other places
in favor of 'active'. A series of minor bug
fixes is applied along the way.

Resolves: #99782
Related: #99747
Releases: main
Change-Id: Ibaef3123b3e6df316ef5e633582077fd0e702be0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77650
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>

Build/Sources/Sass/module/_tstemplate.scss

@@ -11,7 +11,7 @@
     }
 }
 
-.tstemplate-tsobjectbrowser-content {
+.tstemplate-active-content {
     overflow-x: auto;
 }
 

Build/Sources/TypeScript/backend/utility/collapse-state-persister.ts

@@ -104,23 +104,29 @@ export class CollapseStatePersister {
       if (id === '' || !this.shallRecoverState(element)) {
         return;
       }
-      const collapsible = BootstrapCollapse.getOrCreateInstance(element, {
-        toggle: false
-      });
       const storeExpandedState = (element.dataset.persistCollapseStateIfState ?? 'shown') === 'shown';
       const storeHiddenState = (element.dataset.persistCollapseStateIfState ?? 'hidden') === 'hidden';
+      const isExpanded = element.classList.contains('show');
       if (storeExpandedState === true) {
         if (currentStates[id] === true) {
-          collapsible.show();
+          if (!isExpanded) {
+            BootstrapCollapse.getOrCreateInstance(element, { toggle: false }).show();
+          }
         } else {
-          collapsible.hide();
+          if (isExpanded) {
+            BootstrapCollapse.getOrCreateInstance(element, { toggle: false }).hide();
+          }
         }
       }
       if (storeHiddenState === true) {
         if (currentStates[id] === false) {
-          collapsible.hide();
+          if (isExpanded) {
+            BootstrapCollapse.getOrCreateInstance(element, { toggle: false }).hide();
+          }
         } else {
-          collapsible.show();
+          if (!isExpanded) {
+            BootstrapCollapse.getOrCreateInstance(element, { toggle: false }).show();
+          }
         }
       }
     });

Build/Sources/TypeScript/backend/utility/collapse-state-search.ts

@@ -41,11 +41,10 @@ class CollapseStateSearch {
 
   constructor() {
     DocumentService.ready().then(() => {
-      const treeContainers: NodeListOf<HTMLElement>|null = document.querySelectorAll('.t3js-collapse-states-search-tree');
-      if (treeContainers === null) {
+      this.treeContainers = document.querySelectorAll('.t3js-collapse-states-search-tree');
+      if (this.treeContainers.length === 0) {
         return;
       }
-      this.treeContainers = treeContainers;
       this.numberOfSearchMatchesContainer = document.querySelectorAll('.t3js-collapse-states-search-numberOfSearchMatches');
       this.searchField = document.querySelector(this.searchValueSelector);
       this.searchForm = this.searchField.closest('form');
@@ -126,11 +125,15 @@ class CollapseStateSearch {
 
     const allNodes = Array.from(treeContainer.querySelectorAll('.collapse')) as HTMLElement[];
     for (let node of allNodes) {
-      const collapsible = BootstrapCollapse.getOrCreateInstance(node, { toggle: false });
+      const isExpanded = node.classList.contains('show');
       if (matchingCollapsibleIds.has(node.id)) {
-        collapsible.show();
+        if (!isExpanded) {
+          BootstrapCollapse.getOrCreateInstance(node, { toggle: false }).show();
+        }
       } else {
-        collapsible.hide();
+        if (isExpanded) {
+          BootstrapCollapse.getOrCreateInstance(node, { toggle: false }).hide();
+        }
       }
     }
 

typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractNode.php

@@ -36,10 +36,7 @@ abstract class AbstractNode implements NodeInterface
      * @var array<string, ChildNodeInterface>
      */
     protected array $children = [];
-    private bool $expanded = false;
     private ?TokenStreamInterface $originalValueTokenStream = null;
-    private bool $searchMatchInName = false;
-    private bool $searchMatchInValue = false;
     private array $comments = [];
 
     /**
@@ -173,36 +170,6 @@ public function getOriginalValueTokenStream(): ?TokenStreamInterface
         return $this->originalValueTokenStream;
     }
 
-    public function setExpanded(bool $expanded): void
-    {
-        $this->expanded = $expanded;
-    }
-
-    public function isExpanded(): bool
-    {
-        return $this->expanded;
-    }
-
-    public function setSearchMatchInName(): void
-    {
-        $this->searchMatchInName = true;
-    }
-
-    public function hasSearchMatchInName(): bool
-    {
-        return $this->searchMatchInName;
-    }
-
-    public function setSearchMatchInValue(): void
-    {
-        $this->searchMatchInValue = true;
-    }
-
-    public function hasSearchMatchInValue(): bool
-    {
-        return $this->searchMatchInValue;
-    }
-
     public function addComment(TokenStreamInterface $tokenStream): void
     {
         $this->comments[] = $tokenStream;

typo3/sysext/core/Classes/TypoScript/AST/Node/NodeInterface.php

@@ -89,21 +89,6 @@ public function getPreviousValue(): ?string;
     public function setOriginalValueTokenStream(?TokenStreamInterface $tokenStream): void;
     public function getOriginalValueTokenStream(): ?TokenStreamInterface;
 
-    /**
-     * Helper methods mostly for backend object browser to declare a node expanded or not,
-     * and to query expand / collapsed state.
-     */
-    public function setExpanded(bool $expanded): void;
-    public function isExpanded(): bool;
-
-    /**
-     * Helper methods mostly for backend object browser to declare a node matched a search value.
-     */
-    public function setSearchMatchInName(): void;
-    public function hasSearchMatchInName(): bool;
-    public function setSearchMatchInValue(): void;
-    public function hasSearchMatchInValue(): bool;
-
     /**
      * Helper methods to attach TypoScript tokens to a node.
      * This is used in ext:tstemplate "Constant Editor" and "Object Browser" and handled

typo3/sysext/core/Classes/TypoScript/AST/Visitor/AstConstantCommentVisitor.php

@@ -486,12 +486,12 @@ private function parseCustomCategoryAndSubCategories(TokenStreamInterface $comme
 
     public function visit(RootNode $rootNode, NodeInterface $node, CurrentObjectPath $currentObjectPath, int $currentDepth): void
     {
-        // dummy to fulfill interface
+        // Implement interface
     }
 
     public function visitAfterChildren(RootNode $rootNode, NodeInterface $node, CurrentObjectPath $currentObjectPath, int $currentDepth): void
     {
-        // dummy to fulfill interface
+        // Implement interface
     }
 
     private function getLanguageService(): LanguageService