Skip to content

Commit

Permalink
[BUGFIX] Add label information to record history module
Browse files Browse the repository at this point in the history 
Improve the accessibility of the record history module by
binding the label to the related field.

Resolves: #96769
Releases: main, 11.5
Change-Id: If34bce1974c8c98783fdb2529b1555213b1dbc40
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73284
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
@georgringer @lolli42
georgringer authored and lolli42 committed Feb 7, 2022
1 parent c68d43e commit cb0b1b2
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions typo3/sysext/backend/Resources/Private/Partials/RecordHistory/Settings.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<form action="{settingsFormUrl}" name="recordHistorySettingsForm" method="post">
<div class="row row-cols-auto g-3">
<div class="col">
<label class="form-label"><f:translate key="LLL:EXT:backend/Resources/Private/Language/locallang_show_rechis.xlf:maxSteps" /></label>
<select class="form-select form-select-sm" name="settings[maxSteps]" data-global-event="change" data-action-submit="$form">
<label class="form-label" for="maxSteps"><f:translate key="LLL:EXT:backend/Resources/Private/Language/locallang_show_rechis.xlf:maxSteps" /></label>
<select class="form-select form-select-sm" id="maxSteps" name="settings[maxSteps]" data-global-event="change" data-action-submit="$form">
<option value="10" {f:if(condition: '{moduleSettings.maxSteps} == 10', then :'selected')}>10</option>
<option value="20" {f:if(condition: '{moduleSettings.maxSteps} == 20', then :'selected')}>20</option>
<option value="50" {f:if(condition: '{moduleSettings.maxSteps} == 50', then :'selected')}>50</option>
Expand All @@ -12,20 +12,20 @@
</select>
</div>
<div class="col">
<label class="form-label"><f:translate key="LLL:EXT:backend/Resources/Private/Language/locallang_show_rechis.xlf:showDiff" /></label>
<label class="form-label" for="showDiff"><f:translate key="LLL:EXT:backend/Resources/Private/Language/locallang_show_rechis.xlf:showDiff" /></label>
<div class="form-check form-switch">
<input type="hidden" value="0" name="settings[showDiff]" />
<input type="checkbox" value="1" name="settings[showDiff]" data-global-event="change" data-action-submit="$form" class="form-check-input" {f:if(condition: '{moduleSettings.showDiff}', then: 'checked')} />
<input type="checkbox" id="showDiff" value="1" name="settings[showDiff]" data-global-event="change" data-action-submit="$form" class="form-check-input" {f:if(condition: '{moduleSettings.showDiff}', then: 'checked')} />
<label class="form-check-label">
<f:translate key="LLL:EXT:backend/Resources/Private/Language/locallang_show_rechis.xlf:showDiff_inline" />
</label>
</div>
</div>
<div class="col">
<label class="form-label"><f:translate key="LLL:EXT:backend/Resources/Private/Language/locallang_show_rechis.xlf:showSubElements" /></label>
<label class="form-label" for="showSubElements"><f:translate key="LLL:EXT:backend/Resources/Private/Language/locallang_show_rechis.xlf:showSubElements" /></label>
<div class="form-check form-switch">
<input type="hidden" value="0" name="settings[showSubElements]" />
<input type="checkbox" value="1" name="settings[showSubElements]" data-global-event="change" data-action-submit="$form" class="form-check-input" {f:if(condition: '{moduleSettings.showSubElements}', then: 'checked')} />
<input type="checkbox" id="showSubElements" value="1" name="settings[showSubElements]" data-global-event="change" data-action-submit="$form" class="form-check-input" {f:if(condition: '{moduleSettings.showSubElements}', then: 'checked')} />
<label class="form-check-label">
<f:translate key="LLL:EXT:core/Resources/Private/Language/locallang_common.xlf:yes" />
</label>
Expand Down

0 comments on commit cb0b1b2

Please sign in to comment.