Skip to content

Commit

Permalink
[BUGFIX] Encode node name when editing in the page tree
Browse files Browse the repository at this point in the history
Pass page title through encodeURIComponent before using it as request 
parameter value

Releases: master
Resolves: #84019
Change-Id: Ic7b18c752e67d143928e50ff14fcada6ff03c3f9
Reviewed-on: https://review.typo3.org/55870
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
  • Loading branch information
Progowi authored and tmotyl committed Feb 23, 2018
1 parent f677ca2 commit cbbf4aa
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -130,11 +130,11 @@ define(['jquery',

if (data.command === 'new') {
params = '&data[pages][NEW_1][pid]=' + targetUid +
'&data[pages][NEW_1][title]=' + data.name +
'&data[pages][NEW_1][title]=' + encodeURIComponent(data.name) +
'&data[pages][NEW_1][doktype]=' + data.type;

} else if (data.command === 'edit') {
params = '&data[pages][' + data.uid + '][' + data.nameSourceField + ']=' + data.title;
params = '&data[pages][' + data.uid + '][' + data.nameSourceField + ']=' + encodeURIComponent(data.title);
} else {
if (data.command === 'delete') {
params = '&cmd[pages][' + data.uid + '][delete]=1';
Expand Down Expand Up @@ -359,7 +359,7 @@ define(['jquery',
PageTree.prototype.sendEditNodeLabelCommand = function(node) {
var _this = this;

var params = '&data[pages][' + node.identifier + '][' + node.nameSourceField + ']=' + node.newName;
var params = '&data[pages][' + node.identifier + '][' + node.nameSourceField + ']=' + encodeURIComponent(node.newName);

//remove old node from svg tree
_this.nodesAddPlaceholder(node);
Expand Down

0 comments on commit cbbf4aa

Please sign in to comment.